Update DeepFeatureSynthesis to support multiple paths #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For entitysets with multiple paths between two entities DFS will now create features through all paths. Entitysets with cycles in the directed graph are not supported. - Use feature.unique_name instead of hash in dicts - Change EntitySet.get_backward_entities to yield paths.
CJStadler
force-pushed
the
multipath-dfs-no-cycles
branch
from
4e97867
to
42bc4bf
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 97.27% 97.11% -0.16%
==========================================
Files 118 118
Lines 9589 9545 -44
==========================================
- Hits 9328 9270 -58
- Misses 261 275 +14
Continue to review full report at Codecov.
|
kmax12
suggested changes
Jun 18, 2019
Previously was always doing a deep search.
- Add RelationshipPath.entities - Change EntitySet.get_forward_entities to yield entity_ids and paths.
kmax12
suggested changes
Jun 18, 2019
This was not exposed in the dfs method so it always used the default value of 2, it was undocumented, and it was unclear if it provided any value. Also remove EntitySet.find_path as it is no longer used.
This condition can never be True because it were True then the condition in _run_dfs would have been True and would have returned.
kmax12
suggested changes
Jun 19, 2019
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
For entitysets with multiple paths between two entities DFS will now create features through all paths. Entitysets with cycles in the directed graph are not supported. - Use feature.unique_name instead of hash in dicts - Change EntitySet.get_backward_entities and get_forward_entities to yield paths. - Add RelationshipPath which represents a directed path through relationships. - Add RelationshipPath.entities - Warn if dfs produces a feature multiple times - Remove max_hlevel from DFS (alteryx#608). - Remove EntitySet.find_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For entitysets with multiple paths between two entities DFS will now
create features through all paths. Entitysets with cycles in the
directed graph are not supported.
Once #572 is merged the base branch should be changed to master.