Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nlp-primitives #704

Merged
merged 10 commits into from
Aug 16, 2019
Merged

Adding support for nlp-primitives #704

merged 10 commits into from
Aug 16, 2019

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented Aug 12, 2019

Pull Request Description

Incorporates the nlp-primitives PyPI library into Featuretools.

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         118      118           
  Lines       10173    10173           
=======================================
  Hits         9933     9933           
  Misses        240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d904f7b...18f77b3. Read the comment docs.

@kmax12
Copy link
Contributor

kmax12 commented Aug 14, 2019

@ctduffy can you also add to docs/source/getting_started/install.rst? look at how we do it in #699

@ctduffy
Copy link
Contributor Author

ctduffy commented Aug 15, 2019

Add the nlp-primitives API doc to the Featuretools documentation, which will require putting nlp-primitives as a requirement in FT dev reqs

@ctduffy ctduffy requested a review from kmax12 August 16, 2019 20:06
@ctduffy ctduffy merged commit 0bf7210 into master Aug 16, 2019
@ctduffy ctduffy deleted the nlp-prims branch August 16, 2019 20:11
@rwedge rwedge mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants