Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SAM: Probabilities/Edge-Weights greater than 1 from method predict if not fullbatch #164

Open
Infinitif opened this issue Apr 2, 2024 · 0 comments · May be fixed by #165
Open

[BUG] SAM: Probabilities/Edge-Weights greater than 1 from method predict if not fullbatch #164

Infinitif opened this issue Apr 2, 2024 · 0 comments · May be fixed by #165

Comments

@Infinitif
Copy link

Infinitif commented Apr 2, 2024 •
edited
Loading

Describe the bug
If the batchsize is not -1 (i.e. not fullbatch), then the edge weights of the result graph obtained by calling sam.predict() are outside of the domain [0, 1]. This is consistent throughout all cdt-package-, python- and library versions and hardware configurations.
Steps to reproduce: Just set the parameter batch_size to something greater than 1 (eg. 2), test_epochs to sth. greater than 0 and call sam.predict().
@Infinitif Infinitif linked a pull request Apr 2, 2024 that will close this issue
Open
@Infinitif Infinitif changed the title [BUG] SAM + Probabilities/Edge-Weights greater than 1 from method predict if not fullbatch [BUG] SAM: Probabilities/Edge-Weights greater than 1 from method predict if not fullbatch Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Divide SAM filter-output by test_epochs*batch_count Infinitif/CausalDiscoveryToolbox
1 participant
@Infinitif