Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all comparison query operators #251

Closed
8 tasks done
AlekSi opened this issue Jan 13, 2022 · 5 comments · Fixed by #499
Closed
8 tasks done

Support all comparison query operators #251

AlekSi opened this issue Jan 13, 2022 · 5 comments · Fixed by #499
Assignees
@ribaraka
Labels
code/feature Some user-visible feature is not implemented yet
Milestone
v0.2.0

Comments

@AlekSi
Copy link
Member

AlekSi commented Jan 13, 2022 •
edited
Loading

Support all query comparison operators for all data types.

  • $eq
  • $gt
  • $gte
  • $lt
  • $lte
  • $in
  • $ne
  • $nin
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jan 13, 2022
@AlekSi AlekSi changed the title Support all query comparison operators Support all comparison query operators Jan 13, 2022
@AlekSi AlekSi mentioned this issue Jan 13, 2022
Closed
@AlekSi AlekSi added the good first issue Good issues for new external contributors label Jan 13, 2022
@ribaraka
Copy link
Contributor

I would like to work on this one.

@AlekSi
Copy link
Member Author

AlekSi commented Jan 19, 2022

I propose to do everything end-to-end (implementation, tests, integration tests) for one operator (for example, $eq), then do the rest.

@ribaraka
Copy link
Contributor

got it. I will create seperate PRs for each operator.

@AlekSi
Copy link
Member Author

AlekSi commented Jan 19, 2022

Sure, that's a good idea. But I propose is to do and merge one PR first, then start with the rest. Otherwise, you would have to change several PRs after each review cycle and do more busy work in the end.

@ribaraka
Copy link
Contributor

Agreed. I'm going to do one PR after each merge.

This was referenced Feb 22, 2022
Merged
Merged
@ribaraka ribaraka mentioned this issue Mar 1, 2022
Merged
@ribaraka ribaraka mentioned this issue Mar 10, 2022
Closed
@AlekSi AlekSi removed the good first issue Good issues for new external contributors label Mar 19, 2022
@AlekSi AlekSi added this to the v0.1.1 milestone Mar 31, 2022
AlekSi pushed a commit that referenced this issue Apr 1, 2022
@ribaraka
Support $eq comparision operator (#309)
3eda589 
Refs #251.
AlekSi pushed a commit to FerretDB/dance that referenced this issue Apr 1, 2022
@ribaraka
Support $eq comparision operator (#52)
59cecc8 
Refs FerretDB/FerretDB#251.
AlekSi pushed a commit that referenced this issue Apr 4, 2022
@ribaraka
Support $gt comparision operator (#330)
ace0bc9 
Refs #251.
@AlekSi AlekSi mentioned this issue Apr 6, 2022
Merged
AlekSi pushed a commit that referenced this issue Apr 7, 2022
@ribaraka
Add support for $gte, $lt, $lte operators (#452)
a29c029 
Refs #251.
This was referenced Apr 12, 2022
Merged
Merged
@AlekSi AlekSi modified the milestones: v0.1.1, v0.2.0 Apr 18, 2022
AlekSi pushed a commit that referenced this issue Apr 19, 2022
@ribaraka
Add support for $nin operator (#459)
e6c40e1 
Refs #251.
AlekSi pushed a commit that referenced this issue Apr 19, 2022
@ribaraka
Add support for $ne operator (#464)
d088bcb 
Refs #251.
@AlekSi AlekSi mentioned this issue Apr 20, 2022
Merged
AlekSi pushed a commit that referenced this issue Apr 21, 2022
@ribaraka
Add support for $in operator (#499)
5fe6532 
Closes #251.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ribaraka ribaraka

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Add support for $in operator ribaraka/FerretDB
2 participants
@AlekSi @ribaraka