Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $gt comparision operator #330

Merged
merged 11 commits into from
Apr 4, 2022
Merged

Conversation

ribaraka
Copy link
Contributor

@ribaraka ribaraka commented Mar 1, 2022

Refs #251.

@ribaraka ribaraka requested a review from AlekSi as a code owner March 1, 2022 15:55
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Mar 2, 2022
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's finish #309 first

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #330 (15185c0) into main (a64780c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 15185c0 differs from pull request most recent head f7c61ba. Consider uploading reports for the commit f7c61ba to get more accurate results

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   57.60%   57.66%   +0.05%     
==========================================
  Files         117      117              
  Lines        6072     6080       +8     
==========================================
+ Hits         3498     3506       +8     
  Misses       2054     2054              
  Partials      520      520              
Flag Coverage Δ
FerretDB 33.65% <20.00%> (-0.05%) ⬇️
MongoDB 2.84% <0.00%> (-0.01%) ⬇️
integration 33.69% <20.00%> (-0.05%) ⬇️
tests 50.66% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/common/compare.go 85.46% <100.00%> (ø)
internal/handlers/common/filter.go 85.27% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64780c...f7c61ba. Read the comment docs.

@ribaraka ribaraka requested a review from AlekSi April 4, 2022 11:47
internal/handlers/common/compare.go Outdated Show resolved Hide resolved
internal/handlers/common/filter.go Outdated Show resolved Hide resolved
@ribaraka ribaraka requested a review from AlekSi April 4, 2022 13:17
@AlekSi AlekSi merged commit ace0bc9 into FerretDB:main Apr 4, 2022
@AlekSi
Copy link
Member

AlekSi commented Apr 4, 2022

Thank you!

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Apr 4, 2022
@AlekSi AlekSi added this to the v0.1.1 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants