-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support $eq
comparision operator
#309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA, merge with main
, fix CI issues
64d5d8a
to
633408e
Compare
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 57.39% 57.65% +0.25%
==========================================
Files 117 117
Lines 6014 6031 +17
==========================================
+ Hits 3452 3477 +25
+ Misses 2047 2039 -8
Partials 515 515
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
633408e
to
726794b
Compare
726794b
to
4b5a4b1
Compare
Where is a PR to https://github.com/FerretDB/dance? |
77a4035
to
61df501
Compare
$eq
comparision operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of our dance tests fail with MongoDB, meaning that FerretDB and MongoDB behave differently. That's a problem that should be fixed.
I removed the TODO regex from the $eq comparison operator. I have not find any information in the documentation and on the Internet that these two expressions were used. |
Yes.
We should add a dance test for that case and fix that difference in behavior between MongoDB and FerretDB. |
bfeb590
to
b0fd03b
Compare
Thank you! |
Refs #251.