Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker images for git tags (releases) on CI #70

Closed
3 tasks done
ferretdb-bot opened this issue Nov 19, 2021 · 9 comments · Fixed by #1991 or FerretDB/github-actions#134
Closed
3 tasks done

Build Docker images for git tags (releases) on CI #70

ferretdb-bot opened this issue Nov 19, 2021 · 9 comments · Fixed by #1991 or FerretDB/github-actions#134
Assignees
Labels
code/chore Code maintenance improvements project Project maintenance
Milestone

Comments

@ferretdb-bot
Copy link
Member

ferretdb-bot commented Nov 19, 2021

We already build Docker images on CI for PRs and pushes to main, but not for tags.

See also #323.

@ferretdb-bot ferretdb-bot added good first issue Good issues for new external contributors code/feature Some user-visible feature is not implemented yet project Project maintenance labels Nov 19, 2021
@himanshu007-creator
Copy link

himanshu007-creator commented Nov 20, 2021

Hi, i would like to work on this issue! I know just the basics , but i figured out this action might be useful. I might need help.

@ferretdb-bot
Copy link
Member Author

There are two official actions from Docker:

Let's use them if possible, as I expect them to be better supported.

@ferretdb-bot ferretdb-bot added the code/chore Code maintenance improvements label Nov 26, 2021
@Goopil
Copy link

Goopil commented Dec 3, 2021

I could provide some help. I don't know much (yet ?) About golang. But I'm perfectly fine with ci stuff. Ping me if you struggle 🙂

@AlekSi
Copy link
Member

AlekSi commented Dec 7, 2021

@himanshu007-creator are you still working on it, or @Goopil could pick it up?

@himanshu007-creator
Copy link

@himanshu007-creator are you still working on it, or @Goopil could pick it up?

Sorry but I am stuck somewhere else, please @Goopil feel free to continue.

@FerretDB FerretDB deleted a comment from wealthz01 Dec 7, 2021
@Goopil
Copy link

Goopil commented Dec 8, 2021

Hi guys,

just to be sure of what you need before starting

  • Build multi arch x86, arm. Multi repo or prefixed ?
  • each build should have all the label on the image (based on meta-action)
  • the image build should include the build steps of the go or do you prefer a reuse of an already defined actions ?

@AlekSi
Copy link
Member

AlekSi commented Dec 8, 2021

I think it would be better to use a single existing repo with a version tag pointing to a manifest list with two manifests: one for amd64 and one for arm64. (I hope I got the terminology right).

We already have some steps defined in the Makefile that might be useful.

@Goopil
Copy link

Goopil commented Dec 8, 2021

ok so something like this.

docker pull ghcr.io/ferretdb/ferretdb:x64-main
docker pull ghcr.io/ferretdb/ferretdb:arm64-main

docker pull ghcr.io/ferretdb/ferretdb:arm64-0.0.3
docker pull ghcr.io/ferretdb/ferretdb:arm64-latest

docker pull ghcr.io/ferretdb/ferretdb:x64-0.0.3
docker pull ghcr.io/ferretdb/ferretdb:x64-latest

yes thanks you i've seen it. And that help :) like i said i was not sur about the build part as you have no build logic inside of the dockerfile

@AlekSi
Copy link
Member

AlekSi commented Dec 8, 2021

docker pull ghcr.io/ferretdb/ferretdb:x64-main
docker pull ghcr.io/ferretdb/ferretdb:arm64-main

Can that be just docker pull ghcr.io/ferretdb/ferretdb:main, with the right architecture/manifest being selected automatically? I'm not an expert, but this blog post says that's possible.

@AlekSi AlekSi modified the milestone: Alpha Dec 14, 2021
@AlekSi AlekSi assigned pboros and unassigned Goopil Dec 20, 2021
AlekSi pushed a commit that referenced this issue Dec 20, 2021
Build multi-arch image with GitHub Actions on the `main` branch.
Refs #70.
AlekSi added a commit that referenced this issue Jan 4, 2022
@AlekSi AlekSi assigned AlekSi and unassigned pboros Jan 26, 2022
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 28, 2022
@AlekSi AlekSi removed the code/feature Some user-visible feature is not implemented yet label Jan 28, 2022
AlekSi referenced this issue in AlekSi/FerretDB Jan 28, 2022
AlekSi added a commit that referenced this issue Jan 29, 2022
@AlekSi AlekSi removed their assignment Mar 11, 2022
@AlekSi AlekSi modified the milestones: v0.0.7, v0.1.0 Mar 11, 2022
@AlekSi AlekSi removed this from the v0.1.1 milestone Apr 4, 2022
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 17, 2022
@AlekSi AlekSi added this to the v0.8.1 milestone Dec 26, 2022
@AlekSi AlekSi self-assigned this Dec 26, 2022
@AlekSi AlekSi removed the good first issue Good issues for new external contributors label Dec 26, 2022
@AlekSi AlekSi modified the milestones: v0.8.1, v1.0.0 GA Jan 12, 2023
AlekSi added a commit that referenced this issue Jan 12, 2023
@AlekSi AlekSi modified the milestones: v0.8.2, v1.0.0 GA Jan 19, 2023
@AlekSi AlekSi modified the milestones: v1.0.0 GA, v0.9.2 Feb 14, 2023
AlekSi added a commit that referenced this issue Feb 14, 2023
@AlekSi AlekSi reopened this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements project Project maintenance
Projects
None yet
5 participants