-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker images for git tags (releases) on CI #70
Build Docker images for git tags (releases) on CI #70
Comments
Hi, i would like to work on this issue! I know just the basics , but i figured out this action might be useful. I might need help. |
There are two official actions from Docker: Let's use them if possible, as I expect them to be better supported. |
I could provide some help. I don't know much (yet ?) About golang. But I'm perfectly fine with ci stuff. Ping me if you struggle 🙂 |
@himanshu007-creator are you still working on it, or @Goopil could pick it up? |
Sorry but I am stuck somewhere else, please @Goopil feel free to continue. |
Hi guys, just to be sure of what you need before starting
|
I think it would be better to use a single existing repo with a version tag pointing to a manifest list with two manifests: one for amd64 and one for arm64. (I hope I got the terminology right). We already have some steps defined in the Makefile that might be useful. |
ok so something like this. docker pull ghcr.io/ferretdb/ferretdb:x64-main docker pull ghcr.io/ferretdb/ferretdb:arm64-0.0.3 docker pull ghcr.io/ferretdb/ferretdb:x64-0.0.3 yes thanks you i've seen it. And that help :) like i said i was not sur about the build part as you have no build logic inside of the dockerfile |
Can that be just |
Build multi-arch image with GitHub Actions on the `main` branch. Refs #70.
We already build Docker images on CI for PRs and pushes to
main
, but not for tags.v
, and also tag it aslatest
. See Extract multiple Docker tags github-actions#130.ferretdb
andferretdb-dev
).See also #323.
The text was updated successfully, but these errors were encountered: