Securely build and push Docker images #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 51.43% 51.42% -0.01%
==========================================
Files 114 114
Lines 5448 5451 +3
==========================================
+ Hits 2802 2803 +1
- Misses 2229 2231 +2
Partials 417 417
Continue to review full report at Codecov.
|
AlekSi
commented
Jan 28, 2022
.github/workflows/docker.yml
Outdated
| # * We limit what third-party actions can be used. | ||
|
|
||
| # We also tried a different approach: build Docker image in one normal, secure `pull_request` workflow, | ||
| # upload artifact, and the download and publish in another workflow that has access to secrets, but treats |
There was a problem hiding this comment.
Suggested change
| # upload artifact, and the download and publish in another workflow that has access to secrets, but treats | |
| # upload artifact, and then download and publish it in another workflow that has access to secrets, but treats |
pboros
approved these changes
Jan 29, 2022
| switch s.Key { | ||
| case "vcs.revision": | ||
| info.Commit = s.Value | ||
| if s.Value != info.Commit { |
There was a problem hiding this comment.
I like the way that this ensures that the version info which is used for builds is consistent with git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #70.
Closes #224.