Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use - in test collection names #1325

Merged
merged 17 commits into from
Nov 18, 2022
Merged

Use - in test collection names #1325

merged 17 commits into from
Nov 18, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 26, 2022

Description

Closes #1280.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 26, 2022
@AlekSi AlekSi self-assigned this Oct 26, 2022
@vercel
Copy link

vercel bot commented Oct 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 9:12AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 26, 2022 09:45 Inactive
@vercel vercel bot temporarily deployed to Preview October 26, 2022 12:54 Inactive
@AlekSi AlekSi mentioned this pull request Oct 27, 2022
5 tasks
@vercel vercel bot temporarily deployed to Preview October 27, 2022 06:22 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 13:42 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview November 1, 2022 05:19 Inactive
@AlekSi AlekSi closed this Nov 1, 2022
@AlekSi AlekSi deleted the dash branch November 1, 2022 13:23
@AlekSi AlekSi restored the dash branch November 1, 2022 13:23
@AlekSi AlekSi reopened this Nov 1, 2022
@vercel vercel bot temporarily deployed to Preview November 1, 2022 13:26 Inactive
@noisersup noisersup self-assigned this Nov 2, 2022
@vercel vercel bot temporarily deployed to Preview November 3, 2022 10:07 Inactive
@vercel vercel bot temporarily deployed to Preview November 16, 2022 07:48 Inactive
@vercel
Copy link

vercel bot commented Nov 17, 2022

Deployment failed with the following error:

Resource is limited - try again in 59 seconds (more than 100, code: "api-deployments-free-per-day").

@AlekSi AlekSi added this to the v0.7.0 Beta milestone Nov 17, 2022
@vercel vercel bot temporarily deployed to Preview November 18, 2022 06:52 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 06:57 Inactive
@AlekSi AlekSi modified the milestones: v0.7.0 Beta, v0.6.2 Nov 18, 2022
@AlekSi AlekSi marked this pull request as ready for review November 18, 2022 06:59
@AlekSi AlekSi requested a review from a team as a code owner November 18, 2022 06:59
@AlekSi AlekSi requested review from w84thesun, rumyantseva, noisersup, a team and chilagrow and removed request for a team November 18, 2022 06:59
@AlekSi AlekSi enabled auto-merge (squash) November 18, 2022 07:00
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1325 (4964ea4) into main (1dc24a1) will increase coverage by 19.80%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1325       +/-   ##
===========================================
+ Coverage   47.97%   67.78%   +19.80%     
===========================================
  Files         279      279               
  Lines       13500    13500               
===========================================
+ Hits         6477     9151     +2674     
+ Misses       6283     3424     -2859     
- Partials      740      925      +185     
Impacted Files Coverage Δ
integration/setup/setup.go 87.03% <ø> (ø)
internal/util/testutil/db.go 87.30% <100.00%> (ø)
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 50.00% <0.00%> (+1.00%) ⬆️
integration/helpers.go 87.62% <0.00%> (+1.03%) ⬆️
internal/wire/msg_body.go 38.09% <0.00%> (+1.58%) ⬆️
internal/wire/msg_header.go 71.42% <0.00%> (+2.38%) ⬆️
internal/clientconn/listener.go 83.06% <0.00%> (+2.41%) ⬆️
internal/types/document_validation.go 96.15% <0.00%> (+2.56%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
... and 56 more
Flag Coverage Δ
integration 63.99% <100.00%> (+25.32%) ⬆️
mongodb 14.18% <100.00%> (-0.03%) ⬇️
pg 53.16% <100.00%> (?)
tigris 36.14% <100.00%> (-0.03%) ⬇️
unit 26.41% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 18, 2022 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 09:12 Inactive
@AlekSi AlekSi merged commit 0d1ece0 into FerretDB:main Nov 18, 2022
@AlekSi AlekSi deleted the dash branch November 18, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dashes (-) in collection names
4 participants