Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "_id" string to linter exceptions #1364

Merged
merged 21 commits into from
Nov 4, 2022
Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Nov 3, 2022

Description

In this PR "_id" constant was removed and linter settings were tweaked to not trigger a warning.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Nov 3, 2022
@w84thesun w84thesun added this to the v0.6.1 milestone Nov 3, 2022
@w84thesun w84thesun self-assigned this Nov 3, 2022
@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 0:35AM (UTC)

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1364 (c909e5c) into main (2b3100b) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
- Coverage   67.24%   67.13%   -0.11%     
==========================================
  Files         279      279              
  Lines       13228    13228              
==========================================
- Hits         8895     8881      -14     
- Misses       3403     3419      +16     
+ Partials      930      928       -2     
Impacted Files Coverage Δ
internal/types/document.go 87.77% <100.00%> (ø)
internal/types/document_validation.go 96.15% <100.00%> (ø)
internal/handlers/tigris/tigrisdb/errors.go 50.00% <0.00%> (-22.23%) ⬇️
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
internal/handlers/tigris/tigrisdb/databases.go 66.66% <0.00%> (-7.70%) ⬇️
internal/handlers/pg/pgdb/settings.go 41.35% <0.00%> (-4.52%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 86.74% <0.00%> (ø)
internal/handlers/tigris/msg_listdatabases.go 50.70% <0.00%> (+5.63%) ⬆️
Flag Coverage Δ
integration 63.21% <66.66%> (-0.10%) ⬇️
mongodb 14.17% <16.66%> (-0.03%) ⬇️
pg 52.36% <66.66%> (-0.07%) ⬇️
tigris 35.28% <50.00%> (-0.05%) ⬇️
unit 26.27% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 3, 2022 12:39 Inactive
@vercel vercel bot temporarily deployed to Preview November 3, 2022 12:48 Inactive
@vercel vercel bot temporarily deployed to Preview November 3, 2022 12:54 Inactive
@w84thesun w84thesun marked this pull request as ready for review November 3, 2022 13:25
@w84thesun w84thesun requested review from a team and AlekSi as code owners November 3, 2022 13:25
@w84thesun w84thesun requested review from rumyantseva and a team and removed request for a team November 3, 2022 13:25
.golangci.yml Outdated Show resolved Hide resolved
w84thesun added 2 commits November 3, 2022 14:48
@vercel vercel bot temporarily deployed to Preview November 3, 2022 14:56 Inactive
@w84thesun w84thesun requested a review from AlekSi November 3, 2022 15:02
@w84thesun w84thesun enabled auto-merge (squash) November 3, 2022 15:15
@vercel vercel bot temporarily deployed to Preview November 3, 2022 16:00 Inactive
@vercel vercel bot temporarily deployed to Preview November 3, 2022 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview November 4, 2022 00:35 Inactive
@w84thesun w84thesun merged commit b1e7965 into FerretDB:main Nov 4, 2022
@w84thesun w84thesun deleted the fix-id-string branch November 4, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants