Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare documents #1597

Merged
merged 76 commits into from
Dec 8, 2022
Merged

Compare documents #1597

merged 76 commits into from
Dec 8, 2022

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Nov 30, 2022

Description

Closes #1521.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/enhancement Some user-visible feature could work better label Nov 30, 2022
@chilagrow chilagrow self-assigned this Nov 30, 2022
@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 10:05AM (UTC)

@vercel vercel bot temporarily deployed to Preview November 30, 2022 10:38 Inactive
@vercel vercel bot temporarily deployed to Preview December 7, 2022 09:48 Inactive
@vercel vercel bot temporarily deployed to Preview December 7, 2022 10:02 Inactive
@chilagrow
Copy link
Contributor Author

chilagrow commented Dec 7, 2022

Build and codev fail currently 🤔

Packages / Build packages (pull_request) Failing after 3m

#5 [1/1] FROM docker.io/library/debian:11.5@sha[25]
...
ferretdb: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.[32](https://github.com/FerretDB/FerretDB/actions/runs/3637778243/jobs/6139182202#step:6:33)' not found (required by ferretdb)
ferretdb: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.[34](https://github.com/FerretDB/FerretDB/actions/runs/3637778243/jobs/6139182202#step:6:35)' not found (required by ferretdb)
task: Failed to run task "packages": task: Failed to run task "packages-deb": exit status 1
Error: Process completed with exit code 1.

codev

[2022-12-07T10:04:57.851Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
[2022-12-07T10:04:57.852Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
    at main (/snapshot/repo/dist/src/index.js)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2022-12-07T10:04:57.852Z] ['verbose'] End of uploader: 337 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

@vercel vercel bot temporarily deployed to Preview December 7, 2022 12:42 Inactive
rumyantseva
rumyantseva previously approved these changes Dec 7, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks correct to me, and I also like documentation and explanation.

@vercel vercel bot temporarily deployed to Preview December 7, 2022 20:04 Inactive
@chilagrow
Copy link
Contributor Author

Build and codev fail currently thinking

Packages / Build packages (pull_request) Failing after 3m

#5 [1/1] FROM docker.io/library/debian:11.5@sha[25]
...
ferretdb: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.[32](https://github.com/FerretDB/FerretDB/actions/runs/3637778243/jobs/6139182202#step:6:33)' not found (required by ferretdb)
ferretdb: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.[34](https://github.com/FerretDB/FerretDB/actions/runs/3637778243/jobs/6139182202#step:6:35)' not found (required by ferretdb)
task: Failed to run task "packages": task: Failed to run task "packages-deb": exit status 1
Error: Process completed with exit code 1.

codev

[2022-12-07T10:04:57.851Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
[2022-12-07T10:04:57.852Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
    at main (/snapshot/repo/dist/src/index.js)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2022-12-07T10:04:57.852Z] ['verbose'] End of uploader: 337 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Fixed on main now thanks 🙏

w84thesun
w84thesun previously approved these changes Dec 8, 2022
@chilagrow chilagrow dismissed stale reviews from w84thesun and rumyantseva via 9c43a3b December 8, 2022 09:51
@vercel vercel bot temporarily deployed to Preview December 8, 2022 09:52 Inactive
@vercel vercel bot temporarily deployed to Preview December 8, 2022 09:56 Inactive
@vercel vercel bot temporarily deployed to Preview December 8, 2022 10:05 Inactive
@chilagrow
Copy link
Contributor Author

Skipped integration tests failing on tigris.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement document comparison
5 participants