Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement distinct command #1739

Merged
merged 22 commits into from
Jan 5, 2023
Merged

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jan 3, 2023

Description

Closes #945.

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 8:21AM (UTC)

@rumyantseva rumyantseva self-assigned this Jan 3, 2023
@rumyantseva rumyantseva added the code/feature Some user-visible feature is not implemented yet label Jan 3, 2023
@vercel vercel bot temporarily deployed to Preview January 3, 2023 12:34 Inactive
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1739 (e1f0fb9) into main (654f728) will decrease coverage by 0.14%.
The diff coverage is 61.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   69.18%   69.03%   -0.15%     
==========================================
  Files         302      307       +5     
  Lines       14409    14585     +176     
==========================================
+ Hits         9969    10069     +100     
- Misses       3505     3552      +47     
- Partials      935      964      +29     
Impacted Files Coverage Δ
internal/handlers/common/error.go 73.33% <ø> (ø)
internal/handlers/common/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/msg_listcommands.go 100.00% <ø> (ø)
internal/handlers/common/sort_documents.go 91.56% <ø> (ø)
internal/handlers/dummy/msg_distinct.go 0.00% <0.00%> (ø)
internal/handlers/common/distinct.go 54.05% <54.05%> (ø)
internal/handlers/tigris/msg_distinct.go 65.71% <65.71%> (ø)
internal/handlers/pg/msg_distinct.go 65.90% <65.90%> (ø)
internal/handlers/common/sort_array.go 76.19% <76.19%> (ø)
build/version/version.go 63.01% <0.00%> (-4.11%) ⬇️
... and 6 more
Flag Coverage Δ
integration 63.94% <61.36%> (-0.16%) ⬇️
mongodb 5.86% <0.00%> (-0.08%) ⬇️
pg 52.58% <48.29%> (-0.18%) ⬇️
tigris 40.80% <42.04%> (+0.29%) ⬆️
unit 29.08% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview January 3, 2023 12:46 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 16:07 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 17:56 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview January 3, 2023 22:34 Inactive
@vercel vercel bot temporarily deployed to Preview January 4, 2023 12:18 Inactive
@vercel vercel bot temporarily deployed to Preview January 4, 2023 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview January 4, 2023 18:41 Inactive
@vercel vercel bot temporarily deployed to Preview January 4, 2023 18:46 Inactive
@rumyantseva rumyantseva marked this pull request as ready for review January 4, 2023 18:57
@rumyantseva rumyantseva requested a review from a team January 4, 2023 18:57
@rumyantseva rumyantseva requested a review from a team as a code owner January 4, 2023 18:57
@rumyantseva rumyantseva enabled auto-merge (squash) January 4, 2023 18:57
@rumyantseva rumyantseva requested review from a team and noisersup and removed request for a team January 4, 2023 18:58
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one additional edge case test suggestion 🤗

integration/distinct_compat_test.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 5, 2023 02:37 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 08:21 Inactive
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation, though I have one question related to it + a couple of more general questions. If we don't want to change it, I'm ready to approve it!

integration/distinct_compat_test.go Show resolved Hide resolved
integration/distinct_compat_test.go Show resolved Hide resolved
internal/handlers/common/distinct.go Show resolved Hide resolved
@rumyantseva rumyantseva merged commit 6990d98 into FerretDB:main Jan 5, 2023
@rumyantseva rumyantseva deleted the issue-945-distinct branch January 5, 2023 15:42
@rumyantseva rumyantseva added this to the v0.8.1 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement distinct command
4 participants