Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark for replacing large document #2482

Merged
merged 55 commits into from Apr 24, 2023
Merged

Add benchmark for replacing large document #2482

merged 55 commits into from Apr 24, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Apr 19, 2023 •
edited

Description

Closes #2378.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 19, 2023
@noisersup noisersup removed the conflict PRs that have merge conflicts label Apr 19, 2023
@noisersup noisersup marked this pull request as ready for review April 19, 2023 13:09
@noisersup noisersup requested a review from a team as a code owner April 19, 2023 13:09
@noisersup noisersup added the code/chore Code maintenance improvements label Apr 19, 2023
@noisersup noisersup requested review from a team, w84thesun and AlekSi April 19, 2023 13:09
@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited

Codecov Report

Merging #2482 (913587f) into main (1875ff9) will increase coverage by 0.08%.
The diff coverage is 73.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
+ Coverage   26.68%   26.76%   +0.08%     
==========================================
  Files         399      399              
  Lines       19714    19740      +26     
==========================================
+ Hits         5260     5284      +24     
- Misses      13896    13898       +2     
  Partials      558      558
Impacted Files Coverage Δ
integration/shareddata/benchmark.go 62.22% <73.07%> (+14.85%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 5.12% <73.07%> (+0.09%) ⬆️
mongodb 5.12% <73.07%> (+0.09%) ⬆️
unit 25.35% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow reviewed Apr 20, 2023
View reviewed changes
integration/shareddata/benchmark.go Outdated Show resolved Hide resolved
integration/shareddata/benchmark.go Show resolved Hide resolved
integration/benchmarks_test.go Show resolved Hide resolved
w84thesun
w84thesun reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Asked a question about part of generateLargeDocument.

integration/shareddata/benchmark.go Show resolved Hide resolved
@noisersup @chilagrow
Update integration/shareddata/benchmark.go
880259f 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@noisersup noisersup enabled auto-merge (squash) April 20, 2023 11:24
chilagrow
chilagrow approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

integration/benchmarks_test.go Show resolved Hide resolved
rumyantseva
rumyantseva approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noisersup noisersup merged commit 2c858f6 into FerretDB:main Apr 24, 2023
20 checks passed
@noisersup noisersup deleted the benchmarks-large-doc branch April 24, 2023 04:44
@noisersup noisersup mentioned this pull request Apr 24, 2023
Closed
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Introduce integration-level benchmarks
5 participants
@noisersup @w84thesun @rumyantseva @chilagrow @AlekSi