Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for sort and find parameters type #544

Merged
merged 12 commits into from
May 2, 2022
Merged

Add tests for sort and find parameters type #544

merged 12 commits into from
May 2, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Apr 28, 2022 •
edited by AlekSi
Loading

Refs #164.

@w84thesun w84thesun requested a review from AlekSi as a code owner April 28, 2022 13:47
@w84thesun w84thesun self-assigned this Apr 28, 2022
@w84thesun w84thesun added code/chore Code maintenance improvements trust PRs that can access Actions secrets labels Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #544 (cf18777) into main (4fed563) will increase coverage by 0.53%.
The diff coverage is 87.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   60.43%   60.96%   +0.53%     
==========================================
  Files         121      121              
  Lines        6599     6620      +21     
==========================================
+ Hits         3988     4036      +48     
+ Misses       2099     2074      -25     
+ Partials      512      510       -2
Impacted Files Coverage Δ
internal/handlers/common/error.go 80.70% <ø> (ø)
internal/handlers/common/errorcode_string.go 57.69% <44.44%> (+3.52%) ⬆️
internal/handlers/pg/msg_find.go 63.55% <90.00%> (+5.97%) ⬆️
internal/handlers/common/typecode.go 94.73% <95.45%> (+31.65%) ⬆️
internal/handlers/common/params.go 88.57% <0.00%> (+3.80%) ⬆️
Flag Coverage Δ
FerretDB 54.67% <84.12%> (+0.52%) ⬆️
MongoDB 6.58% <0.00%> (-0.03%) ⬇️
integration 54.71% <84.12%> (+0.52%) ⬆️
unit 26.80% <31.74%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

seeforschauer
seeforschauer previously approved these changes Apr 28, 2022
View reviewed changes
AlekSi
AlekSi reviewed Apr 28, 2022
View reviewed changes
integration/query_test.go Outdated Show resolved Hide resolved
integration/query_test.go Show resolved Hide resolved
integration/query_test.go Outdated Show resolved Hide resolved
@w84thesun w84thesun requested a review from AlekSi April 28, 2022 15:26
@w84thesun w84thesun mentioned this pull request May 1, 2022
Merged
@AlekSi AlekSi requested a review from seeforschauer May 2, 2022 10:24
AlekSi
AlekSi reviewed May 2, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question/suggestion and minor comments

integration/query_test.go Outdated Show resolved Hide resolved
integration/query_test.go Outdated Show resolved Hide resolved
integration/query_test.go Outdated Show resolved Hide resolved
internal/handlers/common/typecode.go Outdated Show resolved Hide resolved
Dmitry and others added 2 commits May 2, 2022 13:37
@AlekSi
Update integration/query_test.go
39e0adc 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Update integration/query_test.go
a9c8cfd 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi AlekSi added this to the v0.2.1 milestone May 2, 2022
@w84thesun w84thesun requested a review from AlekSi May 2, 2022 11:04
@w84thesun w84thesun requested a review from AlekSi May 2, 2022 16:10
@AlekSi AlekSi changed the title Add test for sort and find parameters type Add tests for sort and find parameters type May 2, 2022
@AlekSi AlekSi enabled auto-merge (squash) May 2, 2022 16:24
@AlekSi AlekSi merged commit a6fde88 into FerretDB:main May 2, 2022
@AlekSi AlekSi modified the milestones: v0.2.1, v0.2.0 May 4, 2022
AlekSi added a commit to AlekSi/FerretDB that referenced this pull request May 18, 2022
@AlekSi @dependabot
Resolve merge conflicts (#63)
9443dc6 
* Add tests for `sort` and `find` parameters type (FerretDB#544)

Refs #164.

* Prepare v0.2.0 release

* Bump go.mongodb.org/mongo-driver from 1.9.0 to 1.9.1 in /integration (FerretDB#555)

Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/mongodb/mongo-go-driver/releases)
- [Commits](mongodb/mongo-go-driver@v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: go.mongodb.org/mongo-driver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add missing `//nolint` (FerretDB#556)

* Set the handler to use via a command-line flag and remove debug handlers from interface (FerretDB#534)

Closes FerretDB#455.

* Add tests for `RemoveByPath` (FerretDB#549)

Closes FerretDB#479.

* Add `altMessage` to `AssertEqualError` (FerretDB#550)

* Add documentation for values comparision (FerretDB#559)

Refs FerretDB#457.

* Add `debug` and `panic` msg handlers to `Command` map (FerretDB#561)

Refs FerretDB#455.

* Add `RemoveByPath` for `Array` and `CompositeTypeInterface` (FerretDB#560)

Closes FerretDB#479.

* Bump docker/login-action from 1 to 2 (FerretDB#565)

Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add conform CI workflow, improve docs (FerretDB#566)

Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@w84thesun w84thesun deleted the add-sort-test branch May 18, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@seeforschauer seeforschauer Awaiting requested review from seeforschauer

Assignees

@w84thesun w84thesun

Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@w84thesun @AlekSi @seeforschauer