Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for RemoveByPath #549

Merged
merged 10 commits into from
May 4, 2022
Merged

Add tests for RemoveByPath #549

merged 10 commits into from
May 4, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented May 2, 2022 •
edited by AlekSi
Loading

Closes #479.

@codecov
Copy link

codecov bot commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #549 (0bfc1f4) into main (08f0ccd) will increase coverage by 0.10%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   60.77%   60.88%   +0.10%     
==========================================
  Files         121      121              
  Lines        6631     6636       +5     
==========================================
+ Hits         4030     4040      +10     
+ Misses       2090     2085       -5     
  Partials      511      511
Impacted Files Coverage Δ
internal/types/document.go 81.00% <89.47%> (+1.00%) ⬆️
internal/types/types.go 83.52% <0.00%> (+4.70%) ⬆️
Flag Coverage Δ
FerretDB 54.50% <0.00%> (-0.05%) ⬇️
MongoDB 6.56% <0.00%> (-0.01%) ⬇️
integration 54.53% <0.00%> (-0.05%) ⬇️
unit 26.86% <89.47%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@seeforschauer seeforschauer marked this pull request as ready for review May 2, 2022 10:50
@seeforschauer seeforschauer requested a review from AlekSi as a code owner May 2, 2022 10:50
@seeforschauer
Copy link
Contributor Author

A test for RemoveByPath is in the testutil module to avoid import cycle.

@AlekSi
Copy link
Member

AlekSi commented May 2, 2022

A test for RemoveByPath is in the testutil module to avoid import cycle.

Let's move it to types and use assert.Equal as other tests in that package do

@seeforschauer
Copy link
Contributor Author

updated with assert.Equal.

@seeforschauer seeforschauer added this to the v0.2.1 milestone May 3, 2022
@AlekSi AlekSi enabled auto-merge (squash) May 4, 2022 15:07
@AlekSi AlekSi merged commit 285d938 into FerretDB:main May 4, 2022
w84thesun pushed a commit to w84thesun/FerretDB that referenced this pull request May 4, 2022
@seeforschauer
Add tests for RemoveByPath (FerretDB#549)
a1f8743 
Closes FerretDB#479.
@seeforschauer seeforschauer deleted the issue-479-remove-by-path branch May 5, 2022 06:40
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 17, 2022
AlekSi added a commit to AlekSi/FerretDB that referenced this pull request May 18, 2022
@AlekSi @dependabot
Resolve merge conflicts (#63)
9443dc6 
* Add tests for `sort` and `find` parameters type (FerretDB#544)

Refs #164.

* Prepare v0.2.0 release

* Bump go.mongodb.org/mongo-driver from 1.9.0 to 1.9.1 in /integration (FerretDB#555)

Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/mongodb/mongo-go-driver/releases)
- [Commits](mongodb/mongo-go-driver@v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: go.mongodb.org/mongo-driver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add missing `//nolint` (FerretDB#556)

* Set the handler to use via a command-line flag and remove debug handlers from interface (FerretDB#534)

Closes FerretDB#455.

* Add tests for `RemoveByPath` (FerretDB#549)

Closes FerretDB#479.

* Add `altMessage` to `AssertEqualError` (FerretDB#550)

* Add documentation for values comparision (FerretDB#559)

Refs FerretDB#457.

* Add `debug` and `panic` msg handlers to `Command` map (FerretDB#561)

Refs FerretDB#455.

* Add `RemoveByPath` for `Array` and `CompositeTypeInterface` (FerretDB#560)

Closes FerretDB#479.

* Bump docker/login-action from 1 to 2 (FerretDB#565)

Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add conform CI workflow, improve docs (FerretDB#566)

Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@seeforschauer seeforschauer

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.

Add tests for RemoveByPath
3 participants
@seeforschauer @AlekSi @w84thesun