Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology broken for wedges #641

Closed
termi-official opened this issue Mar 24, 2023 · 0 comments · Fixed by #670
Closed

Topology broken for wedges #641

termi-official opened this issue Mar 24, 2023 · 0 comments · Fixed by #670
Assignees
Labels
bug good first issue Something to work on as a new contributor!
Milestone

Comments

@termi-official
Copy link
Member

Forgot to update topology. We also do not have test coverage on this. Problem is that face_npoints is not dispatched (and will require adaption to the new interface. Maybe something like face_npoints(c::Cell,i::Int) = length(faces(c)[i]) is sufficient for all cells.

@termi-official termi-official added bug good first issue Something to work on as a new contributor! labels Mar 24, 2023
@termi-official termi-official changed the title Topology broken for Wedges Topology broken for wedges Mar 24, 2023
@termi-official termi-official added this to the v0.4.0 milestone Mar 25, 2023
@termi-official termi-official self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Something to work on as a new contributor!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant