Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ItemType ids version agnostic. #3

Open
jlnunez89 opened this issue Sep 21, 2020 · 0 comments
Open

Make ItemType ids version agnostic. #3

jlnunez89 opened this issue Sep 21, 2020 · 0 comments

Comments

@jlnunez89
Copy link
Member

Problem

Currently, all Items are created based on an ItemType (think of it as a catalog). Wherever that catalog gets loaded from is not really important, BUT what's important is that these get looked up and instantiated using a numeric ID which is client version specific.

If we want to support multiple versions, we need to make the item instantiation and identification version agnostic.

Solution

One proposed solution would be to use the item name (singular, no article) or another unique string as the identifier, and then map that identifier to the actual numeric value supported by the client in the relevant protocol specific libraries used with dependency injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant