-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Empty files created upon passphrase mismatch #159
Milestone
Comments
FiloSottile
added a commit
that referenced
this issue
Jan 2, 2021
This avoids leaving behind an empty file when an error occurs before we write the header (for example, because the passphrase is invalid). Do a best-effort check before taking user input for whether the file exists so we don't waste user effort. An error might still happen after user input if other kind of open errors happen (for example, a permission issue, or disk full). Fixes #159 Fixes #57 Closes #169
FiloSottile
added a commit
that referenced
this issue
Jan 3, 2021
This avoids leaving behind an empty file when an error occurs before we write the header (for example, because the passphrase is invalid). Do a best-effort check before taking user input for whether the file exists so we don't waste user effort. An error might still happen after user input if other kind of open errors happen (for example, a permission issue, or disk full). Fixes #159 Fixes #57 Closes #169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What were you trying to do
Create an encrypted file using a symmetric key.
What happened
When a passphrase is entered incorrectly, an empty output file is created.
My expectation was that no file would be created until after the program has performed the encryption operation.
The text was updated successfully, but these errors were encountered: