-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move from io/ioutil to io and os packages #353
Conversation
Rerun build step, it appears Filo fixed the Github secret for osslsigncode certkey pass that failed this build. |
@mikecook The build step is still failing. I don't think it has been fixed yet. |
@FiloSottile 's windows build step broke it here 3bd9ab8#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R40 @FiloSottile can you check |
Workflows that use environments are tricky around secrets because of the potential for secret leakage For a private repo you can enable this setting: But for a public repo the secrets aren't shared: https://docs.github.com/en/actions/security-guides/encrypted-secrets#about-encrypted-secrets https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments Options:
|
Environmental secrets are not shared to workflows run from forks without extra work by Maintainers. The existing build workflow uses a secret to sign windows exe's and is breaking for all external PRs. Builds are also probably unnecessary for PRs. See: FiloSottile#353 (comment)
rebase on main and it should work now |
The io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@mikecook Great, the build step now passes. |
The version in the go.mod is not really the minimum supported version, but I don't feel the need to support versions of Go that are out of security support, so we can count on Go 1.16+. |
The
io/ioutil
package has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). Since age has been upgraded to Go 1.17 in 36b0a4f, this PR replaces the existingio/ioutil
functions with their new definitions inio
andos
packages.