Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: ability to specify org name #81

Closed
ldayananda opened this issue Oct 24, 2018 · 3 comments
Closed

feature request: ability to specify org name #81

ldayananda opened this issue Oct 24, 2018 · 3 comments

Comments

@ldayananda
Copy link

Currently the following will use UserAndHostname for certificate subject and Issuer OrganizationalUnit:

mkcert/cert.go

Lines 34 to 39 in fcebdc9

u, _ := user.Current()
if u != nil {
userAndHostname = u.Username + "@"
}
out, _ := exec.Command("hostname").Output()
userAndHostname += strings.TrimSpace(string(out))

It would be nice to be able to specify a different OrganizationalUnit, maybe with -org-unit=

@adamdecaf
Copy link
Contributor

I'm not a fan of this. mkcert is for local dev certificates.

Can you explain the use-case a bit more? If you need a certificate with real details why not get one from a CA?

@ldayananda
Copy link
Author

This is more for sharing with a team for a locally run tool. The hostname being tied to a user is awkward, but not a showstopper.

@FiloSottile
Copy link
Owner

mkcert has as few configuration options as possible by design. I don't think we should add one for this. I understand it's not great to have a username in a team root, but in a sense it helps remember that you are trusting whoever generated it with full MitM capabilities (as they might have a copy of the private key).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants