Make the UUID regex more lenient #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30's build failed initially because a v1 UUID was used rather than v4. There's no issue with using older or newer UUIDs, so I've updated the validation to allow for versions 1–5. This probably also highlights that we should provide some guidance in the documentation on where to get your IDs. Or possibly we should add a command-line tool to help generate them.
lc512k
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #30's build failed initially because a v1 UUID was used rather than
v4. There's no issue with using older or newer UUIDs, so I've updated
the validation to allow for versions 1–5.
This probably also highlights that we should provide some guidance in
the documentation on where to get your IDs. Or possibly we should add a
command-line tool to help generate them.