Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Multiple file upload to S3 from iOS 9 only allows single file selection #1482

Open
PaulParker opened this issue Oct 10, 2015 · 12 comments
Open

Comments

@PaulParker
Copy link

I've got Fine Uploader S3 (jQuery), version 5.3.2 set up with multiple:true and otherwise minimal settings (I removed retry, chunking, resume, etc. for testing, so I just have the policy stuff and other basic UI functionality).

When I open the file uploader on iOS 9, I have the options to select a single file, take a picture/video with the camera, or select a file from the apple cloud storage.

I can see the "multiple" attribute on the file input element via chrome on windows. Everything works as expected on chrome/windows, e.g. the "multiple" property controls whether multiple files can be selected. So I think I've got it set up correctly.

The demo on the fine uploader homepage works. I am able to select multiple files (in addition to taking a picture/video or selecting from cloud) on iOS 9, as I would expect.

Since I backed out most options on my implementation, and multiple file selection works for the demo, but it doesn't work in my implementation, I'm thinking maybe the culprit is fine uploader S3/jquery/.

@PaulParker
Copy link
Author

Oops, I just noticed there's a demo here that's exhibiting the issue I'm experiencing:
http://fineuploader.com/demos.html#amazon-demo

But the main demo at the top does not seem to have the issue.

Wish I'd scrolled down the demos page a little further before spending time to debug the issue on my test platform!

@rnicholus
Copy link
Member

This is not a bug, rather it is intentionally in place to work around bugs in video file uploading present in current iOS Chrome and previous versions of iOS Safari. See #990 for details.

@rnicholus
Copy link
Member

It's possible though that this should only be in place for Chrome. I'll keep this open so I remember to ensure this isn't affecting any version of safari newer than ios7.

@rnicholus rnicholus reopened this Oct 10, 2015
@rnicholus rnicholus modified the milestones: 5.4.0, 6.0.0 Oct 10, 2015
@PaulParker
Copy link
Author

Ok, it would be great to enable multiple video upload on newer iOS Safari if the issue is no longer present.

We get a good amount of traffic from iOS/safari but we have never seen anybody even try to access our website from iOS/chrome.

@PaulParker
Copy link
Author

Is there a way that I can force it to be enabled somehow? I have an iOS/safari multiple upload requirement with a short deadline.

@rnicholus
Copy link
Member

If you set the workarounds.ios8EmptyVideos option to false, it should allow the multiple attribute to be added to the file input in iOS.

@rnicholus
Copy link
Member

In Fine Uploader 6.0, I plan on removing this workaround, even though iOS Chrome may still have this issue. Along with removing the workaround, we'll probably pull support for iOS Chrome. Google doesn't seem to be interested in maintaining Chrome for iOS and there is little reason to use it anymore, especially as serious bugs remain unfixed for 1+ years.

@rnicholus
Copy link
Member

TODO here for 6.0:

  • Remove workarounds.ios8EmptyVideos option
  • Remove support for iOS Chrome
  • Remove workarounds.ios8BrowserCrashoption. This should not be an issue anymore.
  • Remove workarounds.ios8SafariUploads. This was only for iOS 8.0.0.

@PaulParker
Copy link
Author

Great, thanks Ray for the workaround and for the prompt reply (as usual)!

@rnicholus
Copy link
Member

No problem. That's one of the (many) things that makes Fine Uploader a better choice than any of the other upload libraries.

@rnicholus
Copy link
Member

Working on this as part of 6.0.0 now. Again, Chrome on iOS will no longer be supported after this is complete.

@rnicholus
Copy link
Member

Completed and staged in the release/6.0.0 branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants