You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CheckTendermintError also needs to handle ErrTxInMap with correspond { Codespace, Code-Number }, as many GRPC clients want to check TxHash duplication or sequence number duplication error
As many grpc clients want to check sequence number duplication with { Codespace, Code-Number }, it needs to handle ErrTxInMap for GRPC clients, so that it can return { Codespace, Code-Number }
Proposal
Make CheckTendermintError to handle ErrTxInMap
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
CheckTendermintError also needs to handle
ErrTxInMap
with correspond { Codespace, Code-Number }, as many GRPC clients want to check TxHash duplication or sequence number duplication errorProblem Definition
Currently, CheckTendermintError doesn't handle
ErrTxInMap
error ( https://github.com/line/lbm-sdk/blob/main/client/broadcast.go#L59 ),which occurs when Tx is in mempool and not confirmed yet. ( https://github.com/line/ostracon/blob/main/mempool/clist_mempool.go#L302 ).
As many grpc clients want to check sequence number duplication with { Codespace, Code-Number }, it needs to handle
ErrTxInMap
for GRPC clients, so that it can return { Codespace, Code-Number }Proposal
Make CheckTendermintError to handle ErrTxInMap
For Admin Use
The text was updated successfully, but these errors were encountered: