Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CheckTendermintError to handle ErrTxInMap #697

Closed
4 tasks
zbvs opened this issue Oct 5, 2022 · 1 comment
Closed
4 tasks

Make CheckTendermintError to handle ErrTxInMap #697

zbvs opened this issue Oct 5, 2022 · 1 comment

Comments

@zbvs
Copy link

zbvs commented Oct 5, 2022

Summary

CheckTendermintError also needs to handle ErrTxInMap with correspond { Codespace, Code-Number }, as many GRPC clients want to check TxHash duplication or sequence number duplication error

Problem Definition

Currently, CheckTendermintError doesn't handle ErrTxInMap error ( https://github.com/line/lbm-sdk/blob/main/client/broadcast.go#L59 ),
which occurs when Tx is in mempool and not confirmed yet. ( https://github.com/line/ostracon/blob/main/mempool/clist_mempool.go#L302 ).

As many grpc clients want to check sequence number duplication with { Codespace, Code-Number }, it needs to handle ErrTxInMap for GRPC clients, so that it can return { Codespace, Code-Number }

Proposal

Make CheckTendermintError to handle ErrTxInMap


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tkxkd0159
Copy link
Member

We will discard duplicate Tx in the future. (ref)

@tkxkd0159 tkxkd0159 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants