Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the proof.proto path to third_party/proto/confio. #767

Closed
4 tasks
zemyblue opened this issue Oct 27, 2022 · 0 comments · Fixed by #1037
Closed
4 tasks

Change the proof.proto path to third_party/proto/confio. #767

zemyblue opened this issue Oct 27, 2022 · 0 comments · Fixed by #1037
Assignees
@170210
Labels
good first issue Good for newcomers

Comments

@zemyblue
Copy link
Member

Summary of Bug

The proof.proto path of upstream is under the third_party/proto/confio.
But ours path is third_party/proto.

It's difficult to use the cosmjs directly, since the path is difference.
It's generate the problem in lbmjs since the path is difference with cosmjs.
So, we need to change the path.

Version

v0.46.0-rc9

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@170210 170210

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change the proof.proto path to third_party/proto/confio 170210/finschia-sdk
2 participants
@zemyblue @170210