Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test workflow (caused by libsodium modification) #801

Closed
0Tech opened this issue Nov 17, 2022 · 5 comments
Closed

Fix test workflow (caused by libsodium modification) #801

0Tech opened this issue Nov 17, 2022 · 5 comments
Assignees
@ulbqb
Labels
A: CI help wanted Extra attention is needed

Comments

@0Tech
Copy link
Collaborator

0Tech commented Nov 17, 2022 

    CI fails due to the latest changes of workflow in rc9/v0.46.0.

Originally posted by @0Tech in #784 (comment)
@0Tech
Copy link
Collaborator Author

0Tech commented Nov 17, 2022 •
edited
Loading

Related: #793
The CI didn't checked the modification, because there was no diff in go files. So, we should revisit the diff targets.

@0Tech 0Tech added the A: CI label Nov 17, 2022
@ulbqb
Copy link
Member

ulbqb commented Nov 18, 2022 •
edited
Loading

#784
The cause seems to be that libsodium is not installed. I'll fix it.

@ulbqb ulbqb mentioned this issue Nov 18, 2022
Merged
5 tasks
@ulbqb
Copy link
Member

ulbqb commented Nov 18, 2022

@0Tech
How about adding test.yml to diff target in test.yml?

@ulbqb
Copy link
Member

ulbqb commented Nov 18, 2022 •
edited
Loading

I think it's better to add itself to diff target in each other test yml file as well.

@ulbqb ulbqb mentioned this issue Nov 21, 2022
Open
@tkxkd0159 tkxkd0159 added the help wanted Extra attention is needed label Oct 31, 2023
@tkxkd0159
Copy link
Member

Resolved by #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulbqb ulbqb

Labels
A: CI help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0Tech @ulbqb @tkxkd0159