Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant CacheContext() in x/foundation invariants #865

Closed
1 of 4 tasks
0Tech opened this issue Jan 17, 2023 · 0 comments · Fixed by #1167
Closed
1 of 4 tasks

Remove redundant CacheContext() in x/foundation invariants #865

0Tech opened this issue Jan 17, 2023 · 0 comments · Fixed by #1167
Assignees
@170210
Labels
C:x/foundation x/foundation module good first issue Good for newcomers

Comments

@0Tech
Copy link
Collaborator

0Tech commented Jan 17, 2023 •
edited
Loading

Summary

Remove redundant CacheContext() in x/foundation invariants.

Problem Definition

As cosmos/cosmos-sdk#14588 ensures invariants cannot cause side effect to the state, we can remove the same logic in our code.

Proposal

Remove redundant CacheContext() in x/foundation invariants when we apply the patch.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@0Tech 0Tech added good first issue Good for newcomers C:x/foundation x/foundation module labels Jan 17, 2023
@zemyblue zemyblue modified the milestone: v0.47.0-alpha1 Feb 3, 2023
@170210 170210 self-assigned this Jul 21, 2023
@tkxkd0159 tkxkd0159 mentioned this issue Oct 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@170210 170210

Labels
C:x/foundation x/foundation module good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use CacheContext() in AssertInvariants() Finschia/finschia-sdk
3 participants
@zemyblue @0Tech @170210