fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
requested review from
zemyblue,
0Tech and
jaeseung-bae
as code owners
tkxkd0159
added
A: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 69.74% 69.74% -0.01%
==========================================
Files 643 643
Lines 67255 67258 +3
==========================================
+ Hits 46906 46908 +2
- Misses 18176 18177 +1
Partials 2173 2173
|
zemyblue
approved these changes
Mar 12, 2024
jaeseung-bae
approved these changes
Mar 13, 2024
Merged
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 15, 2024
…alidate (backport #1274) (#1281) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (#1274) (cherry picked from commit d9f1133) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
ref. cosmos/cosmos-sdk#16554
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml