Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport #1274) #1281

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 15, 2024

Description

closes: #XXXX

ref. cosmos/cosmos-sdk#16554

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1274 done by [Mergify](https://mergify.com).

…alidate (#1274)

(cherry picked from commit d9f1133)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from tkxkd0159 as a code owner March 15, 2024 08:11
@mergify mergify bot added the conflicts label Mar 15, 2024
@mergify mergify bot requested a review from zemyblue as a code owner March 15, 2024 08:11
Copy link
Contributor Author

mergify bot commented Mar 15, 2024

Cherry-pick of d9f1133 has failed:

On branch mergify/bp/release/v0.48.x/pr-1274
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit d9f1133a7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/auth/types/account.go
	modified:   x/auth/types/account_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (cb6669c) to head (0c789a2).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.48.x    #1281   +/-   ##
================================================
  Coverage            69.78%   69.78%           
================================================
  Files                  646      646           
  Lines                67495    67498    +3     
================================================
+ Hits                 47099    47103    +4     
+ Misses               18210    18209    -1     
  Partials              2186     2186           
Files Coverage Δ
x/auth/types/account.go 76.57% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

@0Tech 0Tech self-assigned this Mar 15, 2024
@0Tech 0Tech added A: bug Something isn't working and removed conflicts labels Mar 15, 2024
@0Tech 0Tech merged commit 647075f into release/v0.48.x Mar 15, 2024
35 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1274 branch March 15, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants