fix: add init logic of module accounts just in case #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 643 643
Lines 67261 67266 +5
=======================================
+ Hits 46909 46914 +5
Misses 18179 18179
Partials 2173 2173
|
jaeseung-bae
added
A: bug
jaeseung-bae
requested review from
tkxkd0159,
zemyblue and
0Tech
as code owners
jaeseung-bae
added
A: State Machine Breaking
You mean, this may have a negative impact on mainnet? |
A newly joined node that tries to sync with our operating node can never sync, because they may have different account number state.
|
ulbqb
previously approved these changes
Mar 15, 2024
0Tech
requested changes
Mar 15, 2024
0Tech
previously approved these changes
Mar 15, 2024
0Tech
previously approved these changes
Mar 15, 2024
0Tech
previously approved these changes
Mar 15, 2024
jaeseung-bae
added
backport/v0.48.x
and removed
A: State Machine Breaking
0Tech
reviewed
Mar 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
* fix: add init logic of module accounts just in case * chore: update changelog * chore: check if module account successfully created * chore: fix lint * chore: add test * chore: fix test (cherry picked from commit 089aff8) # Conflicts: # CHANGELOG.md # x/foundation/keeper/internal/genesis_test.go
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
Mar 19, 2024
…1283) * fix: add init logic of module accounts just in case (#1277) * fix: add init logic of module accounts just in case * chore: update changelog * chore: check if module account successfully created * chore: fix lint * chore: add test * chore: fix test (cherry picked from commit 089aff8) # Conflicts: # CHANGELOG.md # x/foundation/keeper/internal/genesis_test.go * Apply suggestions from code review --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is likely to change account number state in auth module.--> InitGenesis never runs more than onceMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml