-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add init logic of module accounts just in case (backport #1277) #1283
Merged
jaeseung-bae
merged 2 commits into
release/v0.48.x
from
mergify/bp/release/v0.48.x/pr-1277
Mar 19, 2024
Merged
fix: add init logic of module accounts just in case (backport #1277) #1283
jaeseung-bae
merged 2 commits into
release/v0.48.x
from
mergify/bp/release/v0.48.x/pr-1277
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: add init logic of module accounts just in case * chore: update changelog * chore: check if module account successfully created * chore: fix lint * chore: add test * chore: fix test (cherry picked from commit 089aff8) # Conflicts: # CHANGELOG.md # x/foundation/keeper/internal/genesis_test.go
Cherry-pick of 089aff8 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
bot
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
March 17, 2024 03:48
0Tech
reviewed
Mar 19, 2024
0Tech
added
A: bug
Something isn't working
C:x/foundation
x/foundation module
and removed
conflicts
labels
Mar 19, 2024
0Tech
approved these changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.48.x #1283 +/- ##
================================================
Coverage 69.78% 69.78%
================================================
Files 646 646
Lines 67498 67503 +5
================================================
+ Hits 47103 47107 +4
- Misses 18209 18210 +1
Partials 2186 2186
|
jaeseung-bae
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is likely to change account number state in auth module.--> InitGenesis never runs more than onceMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
This is an automatic backport of pull request #1277 done by [Mergify](https://mergify.com).