Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fbridge auth checking bug #1361

Merged
merged 4 commits into from
May 8, 2024
Merged

fix: fbridge auth checking bug #1361

merged 4 commits into from
May 8, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 8, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 added A: bug Something isn't working backport/v0.49.x labels May 8, 2024
@tkxkd0159 tkxkd0159 self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.54%. Comparing base (1c272c9) to head (6f1b355).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   69.53%   69.54%           
=======================================
  Files         672      672           
  Lines       56103    56106    +3     
=======================================
+ Hits        39012    39019    +7     
+ Misses      14827    14824    -3     
+ Partials     2264     2263    -1     
Files Coverage Δ
x/fbridge/keeper/keeper.go 72.41% <100.00%> (+4.55%) ⬆️

... and 1 file with indirect coverage changes

0Tech
0Tech previously approved these changes May 8, 2024
x/fbridge/keeper/keeper_test.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 merged commit 8ad5585 into main May 8, 2024
38 checks passed
@tkxkd0159 tkxkd0159 deleted the bridge-auth-bug branch May 8, 2024 07:59
mergify bot pushed a commit that referenced this pull request May 8, 2024
tkxkd0159 added a commit that referenced this pull request May 8, 2024
(cherry picked from commit 8ad5585)

Co-authored-by: Jaeseung Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants