Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fbridge auth checking bug (backport #1361) #1362

Merged
merged 1 commit into from
May 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1361 done by [Mergify](https://mergify.com).

@tkxkd0159 tkxkd0159 self-assigned this May 8, 2024
@tkxkd0159 tkxkd0159 added the A: bug Something isn't working label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (3301445) to head (7310636).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.49.x    #1362   +/-   ##
================================================
  Coverage            68.90%   68.91%           
================================================
  Files                  675      675           
  Lines                69140    69143    +3     
================================================
+ Hits                 47643    47650    +7     
+ Misses               19220    19217    -3     
+ Partials              2277     2276    -1     
Files Coverage Δ
x/fbridge/keeper/keeper.go 72.34% <100.00%> (+4.20%) ⬆️

... and 1 file with indirect coverage changes

@tkxkd0159 tkxkd0159 merged commit 6bd10bb into release/v0.49.x May 8, 2024
35 checks passed
@tkxkd0159 tkxkd0159 deleted the mergify/bp/release/v0.49.x/pr-1361 branch May 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants