Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade proto buf version #338

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Conversation

egonspace
Copy link

@egonspace egonspace commented Oct 1, 2021

Description

  • upgrade proto buf: v1beta1 -> v1
  • fix buf command: buf check lint -> buf lint
  • buf.yaml -> buf.work.yaml, proto/buf.yaml, third_party/proto/buf.yaml
  • bump up ostracon(20210930060702)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@61fb3d4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage        ?   53.17%           
=======================================
  Files           ?      642           
  Lines           ?    67251           
  Branches        ?        0           
=======================================
  Hits            ?    35758           
  Misses          ?    28549           
  Partials        ?     2944           

@egonspace egonspace added this to the Ebony alpha milestone Oct 1, 2021
@egonspace egonspace changed the title fix: modify proto path; remove beta1 fix: upgrade proto buf version Oct 1, 2021
Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace
Copy link
Author

I merge this before all test passed because the commit prior modifying changelog was successful.

@egonspace egonspace merged commit cfdcb73 into Finschia:main Oct 1, 2021
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Dec 26, 2022
cherry-pick: CosmWasm/wasmd@ae169ce
> Merge pull request Finschia#338 from CosmWasm/fix_genesis_335
>
> Fix param usage issue in genesis import

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants