Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable swagger check temporarily #471

Merged
merged 5 commits into from
Mar 22, 2022
Merged

ci: disable swagger check temporarily #471

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a462dfd
ci: disable swagger check temporarily
0Tech Mar 22, 2022
3a37968
ci: edit proto (revert it later)
0Tech Mar 22, 2022
7added6
docs: update CHANGELOG.md
0Tech Mar 22, 2022
b799097
Revert "ci: edit proto (revert it later)"
0Tech Mar 22, 2022
81e1a5a
docs: update CHANGELOG.md
0Tech Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/proto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ jobs:
with:
go-version: 1.15
- uses: ./.github/actions/generate-swagger
- run: git diff-index --quiet HEAD
- name: diff
run: git diff

# TODO ebony: release comment after merging initial proto files to v2 branch
# breakage:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (ci) [\#457](https://github.com/line/lbm-sdk/pull/457) add swagger check
* (ci) [\#469](https://github.com/line/lbm-sdk/pull/469) publish docker image on tag push
* (ci) [\#471](https://github.com/line/lbm-sdk/pull/471) disable swagger check temporarily
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes is a fix for #457.
Then, how about adding it to line 51 like below?

* (ci) #457, #471 add swagger check

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on squashing the entries as you suggested. But the check would not working after this PR. Let me change the title.

Copy link
Collaborator Author

@0Tech 0Tech Mar 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK to have a title different from it's PR's? Or I cannot change the title because it affects the previous PR (#457).


### Document Updates