Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add swagger check #457

Merged
merged 5 commits into from
Mar 13, 2022
Merged

ci: add swagger check #457

merged 5 commits into from
Mar 13, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 11, 2022

Description

Checks swagger related generated files are in sync.

closes: #456

Motivation and context

#456

How has this been tested?

Push a commit in which the generated files are out of sync, and confirm whether the CI catches it.
And push the revert and confirm it passes.

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. [no need]
  • I have updated the documentation accordingly. [no need]
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml [no need]

@0Tech 0Tech requested review from zemyblue and dudong2 March 11, 2022 02:36
@0Tech 0Tech added github_actions Pull requests that update Github_actions code A: CI labels Mar 11, 2022
@0Tech 0Tech self-assigned this Mar 11, 2022
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 29e2abb into Finschia:main Mar 13, 2022
@0Tech 0Tech deleted the ci branch March 13, 2022 23:14
@0Tech 0Tech mentioned this pull request Mar 22, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: CI github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to be able to check the changes of swagger and statik
3 participants