Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable querying based on mempool status (only gRPC) #840

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Dec 23, 2022

Description

closes: #683

To avoid conflict with upstream, make another createQueryContext function.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #840 (69ed520) into main (85695a4) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   63.13%   63.07%   -0.07%     
==========================================
  Files         869      869              
  Lines      100271   100299      +28     
==========================================
- Hits        63310    63265      -45     
- Misses      33433    33514      +81     
+ Partials     3528     3520       -8     
Impacted Files Coverage Δ
baseapp/abci.go 58.11% <0.00%> (-1.08%) ⬇️
baseapp/grpcserver.go 1.35% <0.00%> (-0.38%) ⬇️
x/token/msgs.go 49.42% <0.00%> (-6.09%) ⬇️
x/collection/msgs.go 47.32% <0.00%> (-5.21%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/token/validation.go 87.27% <0.00%> (+9.09%) ⬆️

@tkxkd0159 tkxkd0159 self-assigned this Dec 26, 2022
@tkxkd0159
Copy link
Member Author

tkxkd0159 commented Dec 26, 2022

codecov/patch said new added lines were not tested but it's not true because they were tested by IntegrationTestSuite. Those lines were hit when I executed tests at the local machine.
-> #844

@tkxkd0159 tkxkd0159 marked this pull request as ready for review December 26, 2022 12:45
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality C:baseapp labels Dec 27, 2022
@jaeseung-bae jaeseung-bae self-requested a review January 3, 2023 06:01
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkxkd0159 tkxkd0159 merged commit 06751bd into Finschia:main Jan 3, 2023
@tkxkd0159 tkxkd0159 deleted the mempool-sequence branch January 3, 2023 10:35
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 12, 2023
* main: (30 commits)
  chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860)
  chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854)
  feat: Remove `x/wasm` module (Finschia#850)
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
  feat: enable querying based on mempool status (only gRPC) (Finschia#840)
  feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848)
  chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847)
  chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841)
  fix: apply foundation audit (Finschia#834)
  chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831)
  chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839)
  ci: automate release process (Finschia#829)
  chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832)
  chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830)
  chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826)
  chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822)
  chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828)
  feat: Get validator pubkey considering KMS (Finschia#821)
  Remove support for composite (BLS) key type (Finschia#817)
  ...

# Conflicts:
#	x/foundation/msgs.go
#	x/wasm/lbmtypes/codec.go
#	x/wasm/types/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:baseapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API to query account sequence number in mempool
3 participants