refactor: Remove useless stub BeginBlock/EndBlock methods #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 63.09% 63.07% -0.02%
==========================================
Files 869 868 -1
Lines 100299 100292 -7
==========================================
- Hits 63280 63258 -22
- Misses 33514 33534 +20
+ Partials 3505 3500 -5
|
jaeseung-bae
requested review from
0Tech,
dudong2,
loin3,
tkxkd0159 and
zemyblue
|
You should apply new interface for module which implement |
…ck implementation meets some interfaces
tkxkd0159
approved these changes
Jan 4, 2023
dudong2
approved these changes
Jan 5, 2023
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jan 6, 2023
* main: refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jan 12, 2023
* main: (30 commits) chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860) chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854) feat: Remove `x/wasm` module (Finschia#850) refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853) feat: enable querying based on mempool status (only gRPC) (Finschia#840) feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848) chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845) chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847) chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841) fix: apply foundation audit (Finschia#834) chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831) chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839) ci: automate release process (Finschia#829) chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832) chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830) chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826) chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822) chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828) feat: Get validator pubkey considering KMS (Finschia#821) Remove support for composite (BLS) key type (Finschia#817) ... # Conflicts: # x/foundation/msgs.go # x/wasm/lbmtypes/codec.go # x/wasm/types/codec.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove useless stub BeginBlock/EndBlock methods
Description
closes: #796
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml