Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove x/wasm module #850

Merged
merged 11 commits into from
Jan 6, 2023
Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jan 3, 2023

Description

Detach x/wasm module to other repository. line/wasmd

Motivation and context

We have had a difficult to bump up the upstream cosmwasm/wasmd in lbm-sdk. Because the commit history is difference and the references git is difference, we cannot use merely git merge. So we need to detach x/wasm module like cosmwasm/wasmd.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue marked this pull request as draft January 3, 2023 14:21
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #850 (83efcea) into main (a3d51b9) will decrease coverage by 0.33%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   63.12%   62.78%   -0.34%     
==========================================
  Files         868      812      -56     
  Lines      100292    92179    -8113     
==========================================
- Hits        63307    57873    -5434     
+ Misses      33457    31055    -2402     
+ Partials     3528     3251     -277     
Impacted Files Coverage Δ
simapp/test_access.go 0.00% <ø> (ø)
testutil/network/network.go 81.60% <ø> (-0.06%) ⬇️
x/ibc/testing/app.go 0.00% <0.00%> (ø)
x/token/event.go 100.00% <ø> (ø)
simapp/test_helpers.go 7.92% <50.00%> (ø)
simapp/app.go 85.04% <100.00%> (-0.28%) ⬇️
simapp/simd/cmd/root.go 89.03% <100.00%> (+6.63%) ⬆️
x/collection/msgs.go 46.87% <0.00%> (-5.66%) ⬇️
x/token/msgs.go 53.99% <0.00%> (+1.52%) ⬆️
x/token/validation.go 89.09% <0.00%> (+1.81%) ⬆️
... and 1 more

Copy link
Member Author

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot add unittest below two parts to indicate no coverage. Because this is IBC integrate test code and it is tested other integration test. So please ignore the codecov/patch error of ci.

@zemyblue zemyblue marked this pull request as ready for review January 4, 2023 07:00
@zemyblue zemyblue self-assigned this Jan 4, 2023
simapp/app_test.go Outdated Show resolved Hide resolved
simapp/app_test.go Outdated Show resolved Hide resolved
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* main:
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
@zemyblue zemyblue merged commit 1ece23d into Finschia:main Jan 6, 2023
@zemyblue zemyblue deleted the remove_wasm_module branch January 12, 2023 11:09
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 12, 2023
* main: (30 commits)
  chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860)
  chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854)
  feat: Remove `x/wasm` module (Finschia#850)
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
  feat: enable querying based on mempool status (only gRPC) (Finschia#840)
  feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848)
  chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847)
  chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841)
  fix: apply foundation audit (Finschia#834)
  chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831)
  chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839)
  ci: automate release process (Finschia#829)
  chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832)
  chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830)
  chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826)
  chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822)
  chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828)
  feat: Get validator pubkey considering KMS (Finschia#821)
  Remove support for composite (BLS) key type (Finschia#817)
  ...

# Conflicts:
#	x/foundation/msgs.go
#	x/wasm/lbmtypes/codec.go
#	x/wasm/types/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants