-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding firebase 3.x authentication methods #882
Adding firebase 3.x authentication methods #882
Conversation
Add the `linkUser` method. FirebaseExtended#764
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
feat(storage): Firebase Storage for AngularFire
…eExtended#899) 1. use $routeChangeError in ngRoute example 2. AccountCtrl won't be initiated in case the route resolve promise is rejected.
…dential() docs (FirebaseExtended#896) * Updated $signInWithPopup() and $signInWithRedirect() docs * Responded to Kato's feedback on auth ref docs updates
Add the `linkUser` method. FirebaseExtended#764
…auth-methods' Conflicts: src/auth/FirebaseAuth.js
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Can we just all agree that CLAs and weird licenses suck? What's the status on this? |
Looked at the commit I pushed back then. Turns out I had my git config with my work email which I no longer have access to 🙁 |
@idanen thank you! :) |
No luck merging the same commit. Submitted a new PR with the same change (but more tests 😊). Take a look at the issue, I think the path to implement isn't decided yet. |
Lost access to the email I made this PR with, so closing... Made a new PR #932 |
Description
Adding the ability to link a user to a new user with email and password.
Code sample
Add the
$linkUser
method. #764