Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some doc updates #899

Merged
merged 1 commit into from
Jan 12, 2017
Merged

some doc updates #899

merged 1 commit into from
Jan 12, 2017

Conversation

idanb11
Copy link
Contributor

@idanb11 idanb11 commented Jan 12, 2017

  1. use $routeChangeError in ngRoute example
  2. AccountCtrl won't be initiated in case the route resolve promise is rejected.

Description

Code sample

@idanb11
some doc updates
24b41bb 
1. use $routeChangeError in ngRoute example
2. AccountCtrl won't be initiated in case the route resolve promise is rejected.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.0% when pulling 24b41bb on idanb11:patch-4 into c22ef72 on firebase:master.

@jwngr jwngr merged commit f2e8333 into FirebaseExtended:master Jan 12, 2017
@jwngr
Copy link

jwngr commented Jan 12, 2017

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idanb11 @coveralls @jwngr