Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmberFire.ObjectArray #6

Closed

Conversation

matthewrudy
Copy link

A variant of the EmberFire.Array which ensures all objects contained are EmberFire.Objects

an Array that always has an EmberFire.Object as its content
@matthewrudy
Copy link
Author

Here is my example app that uses the EmberFire.ObjectArray.
https://github.com/ember-meteor/leaderboard-emberfire

@anantn
Copy link
Contributor

anantn commented Nov 11, 2013

Thanks for the PR! I wonder if this should be the default behavior for EmberFire.Array itself - thoughts @matthewrudy?

@anantn
Copy link
Contributor

anantn commented Nov 11, 2013

Ah, ignore me, you already implemented this in PR #7 👍

@matthewrudy
Copy link
Author

@anantn, #7 was my first attempt to fix EmberFire.Array.
But I realised it was easier to start from scratch with EmberFire.ObjectArray.

I also think this should probably be the behaviour of EmberFire.Array.

Can't see any reason for it not to be.

@matthewrudy
Copy link
Author

@anantn I've done a load more refactoring on another branch
https://github.com/ember-meteor/emberFire/blob/refactor/emberfire-latest.js

I still need to write some tests, so we can define what actually is the spec for the library.
But anyhow,
I hope I'm making progress.

@aputinski aputinski closed this Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants