-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for more purple colors #296
Comments
Also, can we add a Black? For consistency, since we have a white. |
@ericawright sorry if I haven't followed up! Tomorrow I will go through your purple request, usually the rule of thumb for new shades is to use the same hue and play with the saturation/luminance. Regarding the black the rationale behind not including it is that we recommend to never user pitch black in UIs but favor Grey 90 instead. |
I understand the rationale, but unfortunately black seems to be a necessary evil. Not including it, for me, just means I have to make my own variable, because I can't avoid it in this case. |
@ericawright if it's only in this case it's reasonable to have an outlier therefore writing your own variable. But now you made me curious, why and where are you forced to use Regarding the purples the shades that they are suggesting -
I opened FirefoxUX/design-tokens#53.
I am not sure I am fully understanding here, |
sorry, that was a typo, I meant As for the black, I suppose you're right - it's hard to change an existing project away from black though. |
Gotcha, I'll look into it, thanks for the clarification! |
Gonna move the request about a lighter ink shade to the |
See issue FirefoxUX/photon-colors#5 |
I'm combing through the firefox-iOS colors in an attempt to align it more closely to our design system. I'm in need of a lighter purple, something like a Purple40. They are currently using #cf68ff - Purple 50 is too dark, this is displayed on a dark background, and Purple50 is difficult to see.
I'm also in need of something like: #440071, I can get a similar result if I use Purple60 with 30 alpha, but our purples are too red to replace it.
The text was updated successfully, but these errors were encountered: