Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hl7.Fhir.R4B v3.2.0 NuGet package doesn't contain SearchParamDefinitions #1746

Closed
andy-a-o opened this issue Jun 1, 2021 · 5 comments
Closed

Comments

@andy-a-o
Copy link
Contributor

andy-a-o commented Jun 1, 2021

ℹ️ Do you want to ask something or start a discussion, then go here

Describe the bug
We are trying to add R4B functionality into the Spark repo. And we got tests failing because there's no search param defs included into the Hl7.Fhir.R4B package. The defs should be generated, but they are empty in the source code:

Template-ModelInfo.cs

    public static List<SearchParamDefinition> SearchParameters = new List<SearchParamDefinition>()
    {
    };

To Reproduce
Just list the contents of ModelInfo.SearchParameters.

Expected behavior
ModelInfo.SearchParameters list is not empty.

Version used:

  • FHIR Version: R4B
  • Version: 3.2.0
@ewoutkramer
Copy link
Member

ewoutkramer commented Jun 1, 2021

This is indeed the case. HL7 has "forgotten" to include most of the search parameters in the R4B release. We have notified them (see https://jira.hl7.org/browse/FHIR-32782), so I expect that this will be repaired in the next update of FHIR R4B. After HL7 has published a new version, we'll update our NuGets as well.

@ewoutkramer
Copy link
Member

Let's keep it open so we can double check that they have indeed added them for the next release.

@ewoutkramer ewoutkramer reopened this Jun 1, 2021
@ewoutkramer ewoutkramer added the bug label Jun 1, 2021
@marcovisserFurore
Copy link
Member

See also the release notes for 3.2.0 for R4B and other known issues for this release.

@alexzautke
Copy link
Member

At least for R5 (http://hl7.org/fhir/2021May/hl7.fhir.r5.core.tgz) this issue seems to be fixed. Would it be possible to generate the search parameter for R5 for the next release?

@marcovisserFurore
Copy link
Member

This has been resolved in release 3.8.0 of this library. See here for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants