Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviva breaks RPM persistence #18

Closed
JonnyOThan opened this issue May 4, 2023 · 2 comments
Closed

Reviva breaks RPM persistence #18

JonnyOThan opened this issue May 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@JonnyOThan
Copy link
Collaborator

JonnyOThan commented May 4, 2023

When reviva is installed, my cockpits forget what pages are selected on each MFD after scene changes or save/load operations. This does not occur when reviva is not installed.

Repro:

  1. create a vessel containing the mk1 lander can
  2. in the vab, set it to use the RPM IVA
  3. launch the craft
  4. Change one of the MFDs to something non-default
  5. hit F5 to create a quicksave
  6. hold F9 to load the quicksave
  7. Look at the MFD again

If Reviva is installed, all MFDs will start on the default home page. When reviva is not installed, they remember what page they were set to. The persistence information is stored in the RasterPropMonitorComputer partmodule, which I'm pretty sure Reviva is destroying and re-creating. It makes sense to do this if the IVA is changing, but this needs to be avoided if the IVA is the same as the one that is being loaded.

EDIT: correction, the persistence is stored in the vesselcomputer...so not entirely sure how this gets populated back into the MFDs.

@JonnyOThan
Copy link
Collaborator Author

I'm going to rebuild the way RPM does variable persistence because it's pretty gnarly, so don't bother spending any time on this...

@JonnyOThan
Copy link
Collaborator Author

Well, I changed RPM to use OnLoad properly and the persistence still breaks with reviva.

@harveyt harveyt added the bug Something isn't working label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants