Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use the new Iris API in Iris 1.1.4, instead of depending on Iris internals #27

Closed
coderbot16 opened this issue Jan 6, 2022 · 3 comments

Comments

@coderbot16
Copy link

The Iris API isn't distributed separately yet, but it has a much better stability guarantee than reflecting into internal Iris classes. In the future we plan to do reorganization and repackaging which might break things in your mod.

The following two methods should be sufficient: https://github.com/IrisShaders/Iris/blob/41721a53dde15698bf03c6763475c62978105e7c/src/main/java/net/irisshaders/iris/api/v0/IrisApi.java#L64-L90

Ideally, this change could be backported to 1.16.5 and 1.17.1, but I understand if you do not wish to do that.

@FlashyReese
Copy link
Owner

Thank you, I will use the new API and also backport it to previous versions.

@coderbot16
Copy link
Author

coderbot16 commented Jan 6, 2022

Great, thanks! I'll make sure to tag future versions of Iris to run with the latest versions of this mod for each MC version to avoid any potential issues with versions mismatches once we do choose to do any internal refactoring / repackaging.

@FlashyReese
Copy link
Owner

I have released 1.3.0 with the new Iris API changes. I've also included a break clause to prevent users from loading versions prior to Iris 1.1.4. Thanks for providing an API to avoid any issues in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants