Refactor and fix FixCamera#follow()
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a lot of repeated code.
Also, fix tiny typo from a previous commit.
|
One thing though, I haven't actually observed the "jittering" bug (perhaps my eye is not as well trained as most), so I'm not sure if this change brought back the problem. @Dovyski, did you say you had a project with jittering, could you double check this? |
|
@IQAndreas confirmed to be working, no "jittering" bug found in my test project. |
|
I confirm that too, no jittering. It's good to go! I've tested using Flixel Sandbox, Mode and one of my games. |
IQAndreas
added a commit
that referenced
this pull request
Nov 17, 2013
Refactor and fix `FixCamera#follow()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So sorry I procrastinated this, I finally sat down and read through how
FlxCamerahandles following targets (and it was much more simple than I thought it would be).This pull request fixes the last tiny error with
FlxCamera(and I now understand why that*0.25part was accidentally included), but also is tidies upFlxCamera#follow()by merging similar camera styles and renaming variable names to be more descriptive.I have tested and confirmed that it works as expected, at least in Mode. If anyone else wants to test the resulting SWC: