Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored FlxObject::preUpdate() to remove uneccessary code #82

Merged

Conversation

IQAndreas
Copy link
Member

  • Combined two if statements (one of them unnecessary)
  • Replaced an unecessary a=a-b with a-=b

 - Combined two `if` statements (one of them uneccessary)
 - Replaced an uneccessary `a=a-b` with `a-=b`
@moly
Copy link
Member

moly commented Sep 16, 2012

I'm happy with this.

@Dovyski
Copy link
Member

Dovyski commented Sep 17, 2012

Much better :)

@IQAndreas
Copy link
Member Author

A worker at GitHub just showed me a nice way of making that ugly diff much clearer. If you append ?w=1 to the URL, the diff ignores whitespace.

Before
After

Now you can clearly see what I was actually changing. :)

moly added a commit that referenced this pull request Sep 17, 2012
Refactored `FlxObject::preUpdate()` to remove uneccessary code
@moly moly merged commit 5cab4e8 into FlixelCommunity:dev Sep 17, 2012
@IQAndreas IQAndreas mentioned this pull request Oct 15, 2013
5 tasks
@IQAndreas IQAndreas deleted the ref_flxobject_preupdate branch November 17, 2013 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants