Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow.log: Alias for log::Sev::S_NONE: log::OFF. #80

Open
ygoldfeld opened this issue Mar 10, 2024 · 0 comments
Open

flow.log: Alias for log::Sev::S_NONE: log::OFF. #80

ygoldfeld opened this issue Mar 10, 2024 · 0 comments
Labels
enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source

Comments

@ygoldfeld
Copy link
Contributor

ygoldfeld commented Mar 10, 2024

Filed by @ygoldfeld pre-open-source:

(colleague) asked for a stylistic-in-nature addition to flow.log: A constant named something like OFF which can be used to set a log-level to S_NONE, thus disabling all logging in that context (whether per component or globally or...). I guess Sev::S_NONE is arguably less expressive.

If so then an extern flow::log::Sev OFF = flow::log::Sev::S_NONE would perhaps get it done while following the Coding (style) Guide too (global => no S_ prefix). Counterpoint is perhaps it's too general and should be NO_LOGGING or something. Then again flow.log is not so huge, and OFF seems okay since it would be in that namespace.

@ygoldfeld ygoldfeld added enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source
Projects
None yet
Development

No branches or pull requests

1 participant