issue #3885 add checkbox per email for attester key submission #3907
Conversation
martgil
changed the title
|
This pull request introduces 1 alert when merging 35a110b into 5b6b44c - view on LGTM.com new alerts:
|
|
@martgil when you start working on a new branch, make sure that the Now you need to either rebase your work or do the merge commit. |
|
Hello, I have tried to find an account with more than 1 email address/ alias but haven't found one. I suspect that there isn't a test for multiple email alias/addresses exist yet? Is there any hint on this? Thanks in advance! |
|
The ability to include and exclude alias from being submitted to the attester is fully functional. But I haven't added a specific test for checking if there is a checkbox present if the user is in Any suggestion will be appreciated. Thank you in advance 🙇 |
|
Mart, somewhere in the mock server codebase, in google endpoints, will be a |
|
Hello sir @rrrooommmaaa, I hope you're doing well. I can almost finish all the necessary changes here and I was able do detect multiple emails from the I have some difficulty when trying to call the |
Perhaps, |
For the purpose of this PR, let's the easiest option from code perspective. Then we can discuss the rest in a separate issue. |
|
@martgil is this ready for review or are there some questions pending? |
Yes sir, @rrrooommmaaa , I still have a question. I am uncertain how could I fixed the issue of "adding the current user as a contact". While this PR pulls all the addresses and adds them all as contacts. I can't find a clear way yet to deselect email aliases from a backup. |
…m/flowcrypt/flowcrypt-browser into issue-3885-smart-alias-submission
|
Hello sir @rrrooommmaaa, I just fixed the later merge conflict error. I think this is now ready for a review. Thank you! |
* add checkbox per email for attester key submission * fixes tslint error * fixes tslint error * add xss-escaped comment to pass pattern checks * Added test for issue-3885 selectable email aliases to submit on attester * Added a private key with two UIDs * refactor data-test naming and add multi email alias account to google-endpoint.ts * fix tslint error * fix failing test on setup-page-recipe * Added test for importing key with multiple email alias (incomplete) * fixes tslint formatting error * complete test for importing key with multiple email alias * rename data-test and class container * rename data-test and class container * separate the test to CONSUMER-MOCK test variant * move the render display function to key-import-ui.ts * emails for checkboxes are default to 'unchecked' state * remove accidental console.log * Added automatic check/uncheck when an email is present. * fixes tslint by adding interface property * add event of keyup paste and change to manipulate checkboxes * change button color from gray to green when valid private key * remove checkEmailAliasIfPresent and uses fillOnly * use fillOnly completely * bring back checkEmailAliasIfPresent and wrap it in fillOnly * rename css class name to avoid interfering with any className based checking. * added key with multiple aliases * simplified code and move data-test to label input * corrected any type to string * remove spagetti code and better checking for submitkeyforaddrs * exclude email (uncheck checkbox) before submitting * attester pubkey for multi alias user (failing) * added test "setup - imported key from a file with multiple alias" * added test if excluded email was submitted from the attester * collect submitted keys from attester * patch data-test (selector) trasnformer to match/replace any provided selector * move data-test directly to the input * fix inconsistency in checking detected email alias * manipulate test key and added 1 UID * complete neccessary tests by checking default detected key states * refactor email alias process [floating-promise-error] in constructor setup.ts (key-import-ui initPrvImportSrcForm) * remove comment * parse aliases via already rendered input checkbox * patched 'saveKeysAndPassPhrase' on setup.ts * fix conflict * fix conflict * fixes eslint * added callback when performing tests * remove unnecessary undefined initialization * fix pubkey definition * uncheck the checkbox when submit pubkey was set to false * better flow for pubkey submission * check for checkbox state in the first run * fix test title typo * reverted back changes [proposed solution] * clean up setup procedure Co-authored-by: Roman Shevchenko <rrrooommmaaa@mail.ru> Co-authored-by: Mart Gil Robles <mart@Marts-MacBook-Air.local> Co-authored-by: Tom J <6306961+tomholub@users.noreply.github.com> Co-authored-by: Tom <tom@flowcrypt.com> Co-authored-by: Tom J <tom@holub.me>
…4109) * test cancelling passphrase dialog in compose * Change the 'keyup' events handlers to 'input' because text content can be changed with the mouse (#4100) * Change the 'keyup' handlers to 'input' because text content can be changed with the mouse * trigger 'input' events * Upgrade to Puppeteer 11 (#4093) * Upgrade to Puppeteer 11 * unsuccessful attempt to refactor createSecureDraft, add todo for the future * Refactor pageHasSecureDraft() to use getFrame() instead of opening new tab * use getFrame() in Thunderbird tests * workaround sending in the 'secure reply btn, reply draft' test * Simplify openGmailPage() * fail faster - add timeout param to waitAndClick() * wip * handle 'Node is either not clickable' error * wait longer for @action-step0 and @action-step1 * wait longer for @input-compatibility-fix-expire-years * wip * always delete local draft after sending * cleanup * rename mock live test * log * fix 'secure reply btn, reply draft' test * cleanup * do not rely on sleep timeouts * typo * timeout in seconds * let composeBox: Controllable | undefined * #4052 passphrase dialog for non-primary S/MIME signing * Do not show post-it reminder for EKM (#4103) * Do not show post-it reminder for EKM * upd tests * enterPp.expectPostitNoteReminder * Remove expectPostitNoteReminder and related check * Fix the 'Reply' button behavior, align it with Gmail (#4107) * Fix the 'Reply' button behavior, align it with Gmail * copy before iterating * Add tests * add clearRecipientsForReply() to initComposeBox() * Revert * fix the reply button behavior * await promise * Add live gmail test for the reply icon button * simpler namings (#4111) * align 'reply all' behavior with Gmail Co-authored-by: Roman <rrrooommmaaa@mail.ru> * issue #3885 add checkbox per email for attester key submission (#3907) * add checkbox per email for attester key submission * fixes tslint error * fixes tslint error * add xss-escaped comment to pass pattern checks * Added test for issue-3885 selectable email aliases to submit on attester * Added a private key with two UIDs * refactor data-test naming and add multi email alias account to google-endpoint.ts * fix tslint error * fix failing test on setup-page-recipe * Added test for importing key with multiple email alias (incomplete) * fixes tslint formatting error * complete test for importing key with multiple email alias * rename data-test and class container * rename data-test and class container * separate the test to CONSUMER-MOCK test variant * move the render display function to key-import-ui.ts * emails for checkboxes are default to 'unchecked' state * remove accidental console.log * Added automatic check/uncheck when an email is present. * fixes tslint by adding interface property * add event of keyup paste and change to manipulate checkboxes * change button color from gray to green when valid private key * remove checkEmailAliasIfPresent and uses fillOnly * use fillOnly completely * bring back checkEmailAliasIfPresent and wrap it in fillOnly * rename css class name to avoid interfering with any className based checking. * added key with multiple aliases * simplified code and move data-test to label input * corrected any type to string * remove spagetti code and better checking for submitkeyforaddrs * exclude email (uncheck checkbox) before submitting * attester pubkey for multi alias user (failing) * added test "setup - imported key from a file with multiple alias" * added test if excluded email was submitted from the attester * collect submitted keys from attester * patch data-test (selector) trasnformer to match/replace any provided selector * move data-test directly to the input * fix inconsistency in checking detected email alias * manipulate test key and added 1 UID * complete neccessary tests by checking default detected key states * refactor email alias process [floating-promise-error] in constructor setup.ts (key-import-ui initPrvImportSrcForm) * remove comment * parse aliases via already rendered input checkbox * patched 'saveKeysAndPassPhrase' on setup.ts * fix conflict * fix conflict * fixes eslint * added callback when performing tests * remove unnecessary undefined initialization * fix pubkey definition * uncheck the checkbox when submit pubkey was set to false * better flow for pubkey submission * check for checkbox state in the first run * fix test title typo * reverted back changes [proposed solution] * clean up setup procedure Co-authored-by: Roman Shevchenko <rrrooommmaaa@mail.ru> Co-authored-by: Mart Gil Robles <mart@Marts-MacBook-Air.local> Co-authored-by: Tom J <6306961+tomholub@users.noreply.github.com> Co-authored-by: Tom <tom@flowcrypt.com> Co-authored-by: Tom J <tom@holub.me> * issue #4097 add warning when manually importing public keys (#4110) * issue #4097 add warning when manually importing public keys * Improve wording, make import buttons orange * more flexible google mock * allow opening a draft compose box based from inbox.ts in debug mode * fix * added filePath option for addKeyTest * test loading draft with a forgotten non-primary passphrase * merge fix * merge fix * test fix * remark Co-authored-by: Limon Monte <limon.monte@gmail.com> Co-authored-by: martgil <46025304+martgil@users.noreply.github.com> Co-authored-by: Mart Gil Robles <mart@Marts-MacBook-Air.local> Co-authored-by: Tom J <6306961+tomholub@users.noreply.github.com> Co-authored-by: Tom <tom@flowcrypt.com> Co-authored-by: Tom J <tom@holub.me>
This PR grants the ability for the user to choose which email will be sent from the attester, preventing all the email aliases to be submitted.
close #3885 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):