Issue 3952 improve text clarity with password protected email

[martgil]

This PR will improve text clarity with password-protected email

close #3952 // if this PR closes an issue

---

Tests (delete all except exactly one):

• Does not need tests (refactor only, docs or internal changes)
• Tests will be added later (issue #...)

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[rrrooommmaaa]

Well, acctEmail isn't same as senderEmail (as one account can have aliases, so getSender() method exists, input_from visual element appears for such accounts), so we should actually implement and test that the text in the message matches the sender email.
We can copy some of the lines from the test 'standalone - different send from, new signed message, verification in mock' to

1. select an alias to send from (@'input-from')
2. SettingsPageRecipe.addKeyTest -- not needed
3. send -- we can take password sending lines from the test 'compose - PWD encrypted message with flowcrypt.com/api' (file upload is not needed).
4. verification of the resulting message text.
   Verification actually happens in a different place.
   The mock that accepts the sent message uses TestBySubjectStrategyContext constructor to select an obejct (based on partial text from the message subject) to further test the message.
   So if (subject.includes('PWD encrypted message with flowcrypt.com/api')) it will get to PwdEncryptedMessageWithFlowCryptComApiTestStrategy. -- I added a couple of lines there to check that the text matches the sender email -- please pull the change.

So, please implement 3 tests:

1. compatibility account, from flowcrypt.compatibility...
2. compatibility account, from flowcryptcompatibility... alias
3. ci.tests.gmail account -- this account doesn't have any aliases, so no input_from is visible. Make sure it is handled correctly.

[martgil]

Copy sir, @rrrooommmaaa. Thanks for the very helpful context here. I'll be working on this as soon as possible.

[rrrooommmaaa]

Actually, makes more sense to test lang === 'DE', so that all other languages would default to English

[martgil]

Oh, yes! It should definitely work like that! I'll be working on it. Thank you sir!

[martgil]

sir, @rrrooommmaaa. I was able to follow your given instructions which found helpful as usual. When I tried to get combine it and try to read the sent email by email subject using

      const sentMsg = (await GoogleData.withInitializedData(senderEmail)).getMessageBySubject(subject)!;

From here I'm getting undefined as the returned value. I found out that the function getMessageBySubject pulls some data from AcctDataFile? Is there any chance that I need to create another file in the project which contains a message and subject that matches the same subject that I'm including in this test? The specific subject that I'm using is

      const subject = 'PWD encrypted message with flowcrypt.com/api';

which was later could be use in TestBySubjectStrategyContext

Thanks in advance.

[github-actions]

There were 1 email addresses found in the above comment. Please:

1. Click three dots -> edit to remove the email addresses.
2. Click edited in the comment header, and click on the previous revision of the comment.
3. When viewing the old revision with an email in it, click options -> delete this revision from history.

[rrrooommmaaa]

Hi @martgil I think we don't need to extract the sent message like this.
Messages with a subject containing 'PWD encrypted message with flowcrypt.com/api' will go to PwdEncryptedMessageWithFlowCryptComApiTestStrategy. It doesn't save the message to DATA, like some other "strategies" do, like SaveMessageInStorageStrategy.
Other strategies just make some checks and possibly throw an exception, thus making the test fail.
It's enough to set breakpoint in the PwdEncryptedMessageWithFlowCryptComApiTestStrategy, make sure it is actually hit (I've already added a check to compare text with sender e-mail address there -- you should see if you pulled my update) and see if any exception is thrown there in all 3 tests. This is what I meant by 'verification happens in some other place' -- that is, we don't need to verify in the test body. We can verify in this strategy -- it has all the necessary input -- incoming e-mail with "From" and the text. We can simply leave a comment in the test body like Tom did:

      // this test is using PwdEncryptedMessageWithFlowCryptComApiTestStrategy to check sent result based on subject "PWD encrypted message with flowcrypt.com/api"

[martgil]

Ah, you're right @rrrooommmaaa. I finally get it now :) Thank you so much!!